Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): use path instead of name to identify blob when import #7979

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Aug 15, 2024

No description provided.

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 3:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 3:39am

Copy link

graphite-app bot commented Aug 15, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fourdim commented Aug 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fourdim and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4d86d2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@fourdim fourdim marked this pull request as ready for review August 15, 2024 01:10
@fourdim fourdim force-pushed the 08-14-fix_blocks_use_path_instead_of_name_to_identify_blob_when_import branch from 3106ce7 to 48eb54e Compare August 15, 2024 01:20
@fourdim fourdim force-pushed the 08-14-fix_blocks_use_path_instead_of_name_to_identify_blob_when_import branch from 48eb54e to 784a1ea Compare August 15, 2024 01:43
@fourdim fourdim force-pushed the 08-14-fix_blocks_use_path_instead_of_name_to_identify_blob_when_import branch from 784a1ea to d372c51 Compare August 15, 2024 02:15
@fourdim fourdim force-pushed the 08-14-fix_blocks_use_path_instead_of_name_to_identify_blob_when_import branch from d372c51 to de3ce16 Compare August 15, 2024 02:31
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Aug 15, 2024

Merge activity

  • Aug 14, 11:37 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 11:37 PM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Aug 14, 11:42 PM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

@Saul-Mirone Saul-Mirone force-pushed the 08-14-fix_blocks_use_path_instead_of_name_to_identify_blob_when_import branch from de3ce16 to 4d86d2c Compare August 15, 2024 03:37
@graphite-app graphite-app bot merged commit 4d86d2c into master Aug 15, 2024
8 checks passed
@graphite-app graphite-app bot deleted the 08-14-fix_blocks_use_path_instead_of_name_to_identify_blob_when_import branch August 15, 2024 03:42
@fourdim fourdim linked an issue Aug 30, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Notion import - Imported files overrides each other
2 participants