fix: update default basic font-family #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengx17
force-pushed
the
xp/01-23-fix_update_default_basic_font-family
branch
from
94c387c
to
0574ab8
Compare
CatsJuice
approved these changes
Jan 23, 2024
Brooooooklyn
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Jan 24, 2024
this + toeverything/design#110 should fix #5591 fix TOV-457 Reason: HTML requires `lang` to be set to render the correct CJK glyphs. https://heistak.github.io/your-code-displays-japanese-wrong <img width="692" alt="image" src="https://github.com/toeverything/AFFiNE/assets/584378/1d350219-5157-42cb-8e98-76d92d55b41e">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please only check
basicFontFamily. Other changes are only related to code format.