Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time values are not sorted #57

Closed
Jojo-IO opened this issue Aug 22, 2023 · 1 comment · Fixed by #58
Closed

Time values are not sorted #57

Jojo-IO opened this issue Aug 22, 2023 · 1 comment · Fixed by #58
Labels
bug

Comments

@Jojo-IO
Copy link

Jojo-IO commented Aug 22, 2023

Time values like "12:15:10", "12:15:00", "12:15:05" are not sorted, probably because parseFloat returns "12" in all cases.
@tofsjonas tofsjonas added the bug label Aug 22, 2023
@tofsjonas
Copy link
Owner

Indeed. 🤨️

Number instead of parseFloat should fix it. Thanks! 😊️🙏️

tofsjonas added a commit that referenced this issue Aug 22, 2023
@tofsjonas
Number() instead of parseFloat() in compare
ffbae8e 
Fixes #57
@tofsjonas tofsjonas mentioned this issue Aug 22, 2023
Merged
tofsjonas added a commit that referenced this issue Aug 22, 2023
@tofsjonas
Number() instead of parseFloat() in compare (#58)
fea8676 
* Number() instead of parseFloat() in compare
Fixes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Number() instead of parseFloat() in compare tofsjonas/sortable
2 participants
@tofsjonas @Jojo-IO