ComposedLoggedValue: single LoggedValue as several LoggedValues on the top-level #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagroz
requested review from
Odomontois,
danslapman,
catostrophe,
FunFunFine and
oskin1
as code owners
vagroz
force-pushed
the
composed_logged_value
branch
2 times, most recently
from
aa9ee21
to
b73d52f
Compare
vagroz
force-pushed
the
composed_logged_value
branch
from
b73d52f
to
2cbf36b
Compare
FunFunFine
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextMarker allows to provide only single LoggedValue.
Writing ZIO2 logger I faced that I need to collect context (several LoggedValues) from different places (zio-annotations, zio-spans, user-defined context) and put it into ContextMarker. This several logged values (potentially named or constructed from Map[String, A]) must be logged as if they provided in arguments of logging-method.