Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync user preferences #1296

Closed
tcrammond opened this issue Feb 11, 2019 · 3 comments
Closed

Sync user preferences #1296

tcrammond opened this issue Feb 11, 2019 · 3 comments

Comments

@tcrammond
Copy link
Contributor

tcrammond commented Feb 11, 2019

Sync user preferences across browsers, i.e. Firefox Sync and Google Accounts, via web extension APIs.

  • Refactor to use storage.sync API
  • We don't need any kind of setting for this - it's up to the user's sync settings in the browser account.

https://developer.chrome.com/extensions/storage#property-sync

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync

@tcrammond tcrammond added enhancement needs more info An item that is missing information or requires further discussion. labels Feb 11, 2019
@shantanuraj
Copy link
Contributor

shantanuraj commented Feb 20, 2019

Should be toggl-e-able (default to yes)

TC edit: we concluded this is definitely unnecessary, it's up to browser settings.

@shantanuraj
Copy link
Contributor

Should have a reset option

@tcrammond tcrammond removed the needs more info An item that is missing information or requires further discussion. label Feb 20, 2019
@dooart dooart added the estimate: m Medium label Feb 20, 2019
@tcrammond tcrammond self-assigned this Feb 25, 2019
@tcrammond tcrammond added estimate: l Large and removed estimate: m Medium labels Feb 26, 2019
tcrammond added a commit that referenced this issue Mar 13, 2019
Extension settings are saved in synced storage.

- Add storage permission to manifest
- Refactor db.js to use storage.sync api via webextension-polyfill
- Refactor most storage usage and browser messaging to use promise format
- Refactor GA storage usage to promises, stop sending settings. Stopped sending settings becaues the data is not really in a reportable format. This may be handled in #1292.
- Refactor DB message-handling to background page. We cannot have more than one message handler taking the same messages; it breaks everything.
- Reduce storage access when using default project
- Add method to retrieve multiple storage values at once

Closes #1296.
tcrammond added a commit that referenced this issue Mar 13, 2019
tcrammond added a commit that referenced this issue Mar 13, 2019
tcrammond added a commit that referenced this issue Mar 13, 2019
toggl-button-bot added a commit that referenced this issue Mar 13, 2019
# [1.23.0](1.22.2...1.23.0) (2019-03-13)

### Bug Fixes

* Ensure only one websocket is created ([e3d1cbe](e3d1cbe))

### Features

* Migrate settings when upgrading to 1.23.x ([7b497da](7b497da)), closes [#1296](#1296)
* Use WebExtension synced storage ([f936868](f936868)), closes [#1292](#1292) [#1296](#1296)
* **settings:** Add "Reset settings" feature to Settings ([d1fc44f](d1fc44f)), closes [#1317](#1317)
@toggl-button-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants