Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sync user preferences] Allow resetting button settings #1317

Closed
shantanuraj opened this issue Feb 20, 2019 · 1 comment
Closed

[Sync user preferences] Allow resetting button settings #1317

shantanuraj opened this issue Feb 20, 2019 · 1 comment
Assignees
@tcrammond
Labels
estimate: s Small released

Comments

@shantanuraj
Copy link
Contributor

shantanuraj commented Feb 20, 2019 •
edited
Loading

image

  • Add an option in settings to restore toggl button to factory settings.
  • The button should clearly indicate it is an irreversible action.
  • The user's login session should remain unaffected.
  • All user configurable settings should be reverted to the default options.
@dooart dooart added estimate: s Small needs more info An item that is missing information or requires further discussion. labels Feb 20, 2019
@tcrammond tcrammond self-assigned this Feb 28, 2019
@shantanuraj shantanuraj removed the needs more info An item that is missing information or requires further discussion. label Feb 28, 2019
tcrammond added a commit that referenced this issue Feb 28, 2019
@tcrammond
Add "Reset settings" feature to Settings
004365a 
Closes #1317.
tcrammond added a commit that referenced this issue Feb 28, 2019
@tcrammond
Log out user after resetting settings
51ab71b 
There are many stateful things that should be reset. Logging out is the safest way for this rare action. Part of #1317.'
@tcrammond tcrammond mentioned this issue Feb 28, 2019
Merged
tcrammond added a commit that referenced this issue Mar 4, 2019
@tcrammond
Add "Reset settings" feature to Settings
f4ba039 
Closes #1317. Also log out user after resetting; this is the safest way to "reset" the extension and its state.
tcrammond added a commit that referenced this issue Mar 4, 2019
@tcrammond
Add "Reset settings" feature to Settings
959697a 
Closes #1317. Also log out user after resetting; this is the safest way to "reset" the extension and its state.
tcrammond added a commit that referenced this issue Mar 11, 2019
@tcrammond
Add "Reset settings" feature to Settings
2136b9e 
Closes #1317. Also log out user after resetting; this is the safest way to "reset" the extension and its state.
tcrammond added a commit that referenced this issue Mar 13, 2019
@tcrammond
feat(settings): Add "Reset settings" feature to Settings
428f218 
- Closes #1317. Also log out user after resetting; this is the safest way to "reset" the extension and its state.

- Use background page database in bugsnag. In some instances, such as settings, db may not be present in the global scope already. DB class needs refactoring to not rely on global state, possibly.

- Refresh settings page after resetting settings
tcrammond added a commit that referenced this issue Mar 13, 2019
@tcrammond
feat(settings): Add "Reset settings" feature to Settings
f225eca 
- Closes #1317. Also log out user after resetting; this is the safest way to "reset" the extension and its state.

- Use background page database in bugsnag. In some instances, such as settings, db may not be present in the global scope already. DB class needs refactoring to not rely on global state, possibly.

- Refresh settings page after resetting settings
toggl-button-bot added a commit that referenced this issue Mar 13, 2019
@toggl-button-bot
chore(release): 1.23.0 [skip ci]
5250435 
# [1.23.0](1.22.2...1.23.0) (2019-03-13)

### Bug Fixes

* Ensure only one websocket is created ([e3d1cbe](e3d1cbe))

### Features

* Migrate settings when upgrading to 1.23.x ([7b497da](7b497da)), closes [#1296](#1296)
* Use WebExtension synced storage ([f936868](f936868)), closes [#1292](#1292) [#1296](#1296)
* **settings:** Add "Reset settings" feature to Settings ([d1fc44f](d1fc44f)), closes [#1317](#1317)
@toggl-button-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcrammond tcrammond

Labels
estimate: s Small released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dooart @shantanuraj @tcrammond @toggl-button-bot