Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remind me to track" from time doesn't save when changed #1339

Closed
tcrammond opened this issue Mar 13, 2019 · 10 comments
Closed

"Remind me to track" from time doesn't save when changed #1339

tcrammond opened this issue Mar 13, 2019 · 10 comments
Labels
bug released

Comments

@tcrammond
Copy link
Contributor

  • OS version: *
  • Browser version: *
  • Extension version: Latest

🐛 Describe the bug

Changing the "from" time of the tracking reminder does not save by itself. It is only saved when you changed the "to" time.

Expected behaviour

Changes to only the "from" time is saved.

Steps to reproduce

Steps to reproduce the behaviour:

  1. Go to settings
  2. Change the reminder "From" time and blur the field
  3. Refresh settings
  4. Your change was not saved.

Other details or context

Looks like the event handler is incorrectly calling Settings.saveSetting(); without any values.
@tcrammond tcrammond added the bug label Mar 13, 2019
@nicktoggl nicktoggl mentioned this issue Mar 14, 2019
Closed
@epagnini epagnini mentioned this issue Mar 14, 2019
Closed
@nicktoggl
Copy link

https://app.intercom.io/a/apps/ayixs927/inbox/inbox/2097915/conversations/21192008290

@nicktoggl
Copy link

https://app.intercom.io/a/apps/ayixs927/conversations/21189600004
https://app.intercom.io/a/apps/ayixs927/conversations/21192008290
https://app.intercom.io/a/apps/ayixs927/conversations/21192097547

Referencing cases for examples and to contact users when fixed

@epagnini
Copy link

Case
Case

@epagnini
Copy link

epagnini commented Mar 14, 2019 •
edited
Loading

Case

@epagnini
Copy link

Case

@epagnini
Copy link

Case

@nicktoggl
Copy link

At the moment we're recommending users disable the extension to prevent the problem from occurring, That is working as an option while we await a solution.

shantanuraj added a commit that referenced this issue Mar 14, 2019
@shantanuraj
fix(settings): From interval not being saved
90f35c0 
Closes #1339
@shantanuraj shantanuraj mentioned this issue Mar 14, 2019
Merged
shantanuraj added a commit that referenced this issue Mar 14, 2019
@shantanuraj
fix(settings): From interval not being saved
97f569f 
Closes #1339
toggl-button-bot added a commit that referenced this issue Mar 14, 2019
@toggl-button-bot
chore(release): 1.23.2 [skip ci]
ef87f93 
## [1.23.2](1.23.1...1.23.2) (2019-03-14)

### Bug Fixes

* **settings:** From interval not being saved ([97f569f](97f569f)), closes [#1339](#1339)
@toggl-button-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.23.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@nicktoggl
Copy link

Just marking that all users were contacted

@DivineMK
Copy link

DivineMK commented Apr 9, 2024

This issue occurs to me for both from and to keys. I am using Linux, Firefox with Toggl Track 3.0.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tcrammond @epagnini @nicktoggl @DivineMK @toggl-button-bot