-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Xero): Fix showing Toggl Button in Xero #2022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of already asked for this on the question I asked on your other PR
But for Xero instead 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't ask me to. It might have became suspicious of why two people from different part of the globe logged in on the same day after weeks of no activity :) |
@tiberiusuciu I have double-checked the fix – it wasn't there due to host selector changes and now it is. Looking 👌 as you can see from the screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiberiusuciu it is supposed to be visible where the header is. I've recorded a short demo video: https://cln.sh/SHqBXr |
5d09faf
to
f7aff3b
Compare
Rebased and removed double-declarations from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we made this repo private, but I can't seem to find the instruction on how to set up the extension locally to test it out. Could anyone refer me to this documentation? 👀
I've brought this up in Slack, but here's how I've been able to run it:
resolve: {
extensions: ['.tsx', '.ts', '.js', '.jsx'],
alias: {
'webextension-polyfill': path.resolve(__dirname, 'node_modules/webextension-polyfill')
}
}, Not sure why, but it doesn't want to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new repos on my machine and with the proper configuration, I was able to see the Toggl button visible on Xero.
It's working now! Let's just address the merge-conflict and this PR is good to go!
f7aff3b
to
ec9db6e
Compare
ec9db6e
to
5cca2c9
Compare
🌟 What does this PR do?
Fixes the broken selectors for Xero, so that Toggl Button appears in place.
🐛 Recommendations for testing
📝 Links to relevant issues or information
#1910