Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taiga): Fix taiga.io integration #2037

Merged
merged 3 commits into from
Jan 29, 2022
Merged

fix(taiga): Fix taiga.io integration #2037

merged 3 commits into from
Jan 29, 2022

Conversation

EternallLight
Copy link
Contributor

@EternallLight EternallLight commented Jan 20, 2022

馃専 What does this PR do?

Fixes integrations for taiga.io

馃悰 Recommendations for testing

Sign in to taiga.io with your github account and try to click around.

You're going to need to create both Kanban and Scrum projects.

Here's the video where to find the Toggl Button in both of them.

Check where the button should show up.

馃摑 Links to relevant issues or information

Closes #1929

@EternallLight EternallLight requested a review from a team January 20, 2022 11:44
@EternallLight EternallLight self-assigned this Jan 20, 2022
@EternallLight EternallLight marked this pull request as ready for review January 24, 2022 12:01
Copy link
Contributor

@LulzAugusto LulzAugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to test this but after cloning track-extension-core and pointing the track-extension to "@toggl/track-extension": "toggl/track-extension#1929/taiga-fix", and trying to run I get a webpack error, both from yarn start and yarn build. Any other ways of testing this?

And yeah, I deleted node_modules and ran yarn install from scratch. And even without altering the dependency for track-extension I'm having this error. 馃

@EternallLight
Copy link
Contributor Author

@LulzAugusto here is the recipe how to test it now.

I really need to put it in the readme next week :)

Copy link
Contributor

@LulzAugusto LulzAugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button was visible in all views 馃檶

@EternallLight EternallLight merged commit 5df3c58 into master Jan 29, 2022
@EternallLight EternallLight deleted the 1929/taiga-fix branch January 29, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taiga has updated their UI so the button no longer shows up
2 participants