Introduce 'Endpoint' and launch endpoints in tasks. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
approved these changes
Jan 13, 2024
| backoff := Duration --s=5 | ||
| logger.info "backing off for $backoff" | ||
| sleep backoff | ||
| endpoints := [ |
There was a problem hiding this comment.
It would be nice to get these endpoints passed in to serve from the outside, so the configuration step is nicely split from the logic.
There was a problem hiding this comment.
will address this in a follow-up PR.
| // If Jaguar needs to be disabled, we stop here and wait until | ||
| // we can re-enable Jaguar. | ||
| if disabled: | ||
| network-free.up // Signal to start running the container. |
There was a problem hiding this comment.
This feels a bit weird now. The endpoint may not be network related? Should this be a call to the endpoint? Or should it just be renamed to jaguar-disabled.up?
There was a problem hiding this comment.
Agreed.
Will do a follow-up PR.
| backoff := Duration --s=5 | ||
| logger.info "backing off for $backoff" | ||
| sleep backoff | ||
| Task.group lambdas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.