Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use '-uart' suffix for proxied devices #472

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

floitsch
Copy link
Member

No description provided.

@floitsch floitsch requested a review from kasperl January 16, 2024 12:07
@@ -201,7 +201,7 @@ func createIdentityPayload(identity *uartIdentity, localIP string, localPort int
jsonIdentity := map[string]interface{}{
"method": "jaguar.identify",
"payload": map[string]interface{}{
"name": identity.Name + "-uart",
"name": identity.Name + "^uart",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the hat, so much.

@floitsch floitsch changed the title Drop 'uart' suffix for proxied devices during firmware update. Don't use '-uart' suffix for proxied devices Jan 17, 2024
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floitsch floitsch merged commit 4ebd0a9 into main Jan 17, 2024
7 checks passed
@floitsch floitsch deleted the floitsch/uart-name branch January 17, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants