Print name of device that is being proxied. #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
reviewed
Jan 22, 2024
cmd/jag/commands/proxy_network.go
Outdated
| @@ -214,7 +214,7 @@ func runProxyServer(ud *uartDevice, identity *uartIdentity) error { | |||
| }) | |||
|
|
|||
| // TODO(florian): this print should be a log. | |||
| fmt.Printf("Proxying device through 'http://%s:%d'.\n", localIP, localPort) | |||
| fmt.Printf("Proxying device %s through 'http://%s:%d'.\n", identity.Name, localIP, localPort) | |||
There was a problem hiding this comment.
Maybe we should make this look more like the output you get from the device? It looks like app output as is.
https://github.com/toitlang/jaguar/blob/main/src/network.toit#L45
There was a problem hiding this comment.
Not sure.
I would almost like to make the monitor output less like the output from the device.
There was a problem hiding this comment.
Then you'll have three things you have to distinguish.
kasperl
approved these changes
Jan 22, 2024
|
PTAL. |
kasperl
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.