Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InitializeSpecShim is not defined issue #64

Closed
wants to merge 2 commits into from

Conversation

huningxin
Copy link
Contributor

Fix #63

@huningxin
Copy link
Contributor Author

@toji , PTAL. Thanks!

@toji
Copy link
Owner

toji commented Jun 7, 2017

Hm, upon looking at this it seems that the function name was a typo? We probably want the pages to be calling "InstallWebVRSpecShim" instead, to avoid ambiguity and having two names for the same thing. As for the function not being exported, that should be fixed in the main polyfill library so that we don't lose this change the next time we update from source.

@huningxin
Copy link
Contributor Author

From the log, it seems the InstallWebVRSpecShim patch is lost in latest webvr-polyfill update commit.

Fix in the webvr-polyfill library sounds a better solution. I will do that.

@huningxin
Copy link
Contributor Author

I send a PR immersive-web/webvr-polyfill#259 to expose InstallWebVRSpecShim. Once webvr-polyfill is updated, all samples need to replace InitializeSpecShim with InstallWebVRSpecShim.

@huningxin
Copy link
Contributor Author

Updated the PR, @toji , please take another look. Thanks!

@huningxin
Copy link
Contributor Author

ping @toji . Thanks!

@toji
Copy link
Owner

toji commented Dec 20, 2017

Thanks for your work on this and sorry it was never merged. The issue has been rendered moot by #85

@toji toji closed this Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants