Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitializeSpecShim is not defined #63

Closed
jsantell opened this issue May 26, 2017 · 2 comments · Fixed by immersive-web/webvr-polyfill#259
Closed

InitializeSpecShim is not defined #63

jsantell opened this issue May 26, 2017 · 2 comments · Fixed by immersive-web/webvr-polyfill#259

Comments

@jsantell
Copy link
Contributor

When using the non-polyfilled version of sites, InitializeSpecShim is called which doesn't exist. I'm guessing it should be using this function from the polyfill, and if so, we should explicilty make it clear that that function should be exposed from the polyfill
huningxin added a commit to huningxin/webvr.info that referenced this issue Jun 7, 2017
@huningxin
Fix InitializeSpecShim is not defined issue
6455928 
Fix toji#63
This was referenced Jun 7, 2017
Closed
Merged
huningxin added a commit to huningxin/webvr.info that referenced this issue Aug 2, 2017
@huningxin
Change to use WebVRPolyfill.InstallWebVRSpecShim()
d7c6265 
Fix toji#63
@huningxin
Copy link
Contributor

It still requires to update webvr-polyfill and replace InitializeSpecShim with InstallWebVRSpecShim in this repo. I updated the #64 accordingly.

@toji
Copy link
Owner

toji commented Dec 20, 2017

The call in question has been removed entirely as of #85. Leaving this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose InstallWebVRSpecShim huningxin/webvr-polyfill
3 participants
@jsantell @toji @huningxin