OR-1534 update bindings template #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenzung
requested review from
theo-learner,
ohbyeongmin,
steven94kr,
AaronLee22,
xxeonge and
0x6e616d
|
I'm sorry. I haven't check this code... @AaronLee22 |
steven94kr
approved these changes
Apr 17, 2024
nguyenzung
force-pushed
the
OR-1534-thanos-canyon-fix-generate-go-binding
branch
from
4101594
to
63f9d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed when running devnet with new generated-bindings (by cd op-bindings, "make" and start make devnet-up"
Fix: update bindings template file, refer to: https://github.com/tokamak-network/tokamak-thanos/blob/OR-1257-Update-smart-contracts-for-deposit-TON-in-L1/op-bindings/gen/main.go
I am not sure why the source map generator part was deleted. Please let me know if you have ideas.
Thank you very much!