Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR-1525 update e2e-test for bridge #129

Conversation

nguyenzung
Copy link
Member

Update e2e test for bridges: add withdrawal cases

Thank you!

@steven94kr
Copy link
Member

@nguyenzung
Thank you very much!
I think we can use same name. I recommend WNativeToken instead of L1Token,,, 🙇🏼‍♂️ Is it weird a little?,,, I'm sorry,,, 🥹🥲

@nguyenzung
Copy link
Member Author

nguyenzung commented Apr 16, 2024

@nguyenzung Thank you very much! I think we can use same name. I recommend WNativeToken instead of L1Token,,, 🙇🏼‍♂️ Is it weird a little?,,, I'm sorry,,, 🥹🥲

Thank you very much, Steven

Let me update it!

@rlgns98kr I just checked it again. L1Token is used for an ERC20 token when testing deposit/withdraw ERC20. It is not WNativeToken

@steven94kr
Copy link
Member

@nguyenzung Thank you very much! I think we can use same name. I recommend WNativeToken instead of L1Token,,, 🙇🏼‍♂️ Is it weird a little?,,, I'm sorry,,, 🥹🥲

Thank you very much, Steven

Let me update it!

@rlgns98kr I just checked it again. L1Token is used for an ERC20 token when testing deposit/withdraw ERC20. It is not WNativeToken

LEGACY_ERC20_NATIVE_TOKEN = 0xDeadDeAddeAddEAddeadDEaDDEAdDeaDDeAD0000;
-> It's is just for legacy support
WNativeToken = "0x4200000000000000000000000000000000000006"
-> It's is for WETH9 (to use uniswap,,, etc...)

I think the name is weird a little. I'm sorry again. I tried to change the name of ETH to NativeToken...

In the test code, It's used to check about erc20 dep/with as you said. But I think if we use WNativeToken contract as ERC20 for that, we have to use same naming...🙇🏼‍♂️

Copy link
Member

@steven94kr steven94kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 🙇🏻‍♂️❤️❤️

@nguyenzung nguyenzung merged commit 8749f57 into OR-1257-Update-smart-contracts-for-deposit-TON-in-L1 Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants