Or 1276 setup tokamak packages #27
Conversation
| @@ -0,0 +1,27 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
I think we can move these files in packages/contracts-bedrock to packages/tokamak/contracts-bedrock. 🙇🏼♂️
There was a problem hiding this comment.
Sorry. It's my mistake. Let me fix it.
There was a problem hiding this comment.
I think we dont really need TON contract here. TON is a deployed smart contract. The current version is also working well with arbitrary ERC-20 token. What we need is ERC-20 addresses.
There was a problem hiding this comment.
I agree. How about adding in L2 to use predeploys instead of L1?
There was a problem hiding this comment.
I am not sure!
It seems that there are similar contracts on packages/contracts-bedrock/src/legacy for predeploy.
Maybe we can add to L2 and if we can use legacy contracts, we will update source code later
There was a problem hiding this comment.
@rlgns98kr @nguyenzung
You have some confusion due to my lack of background. L1 TON is used for manual deployment in the devnet. We need to provide users with the code to create a devnet environment.
So I think we have to fix the deploy script (packages/tokamak/contracts-bedrock/script/Deploy.s.sol):
- you can check the chain id or something so that we can determine if it's a devnet or live network.
2.1 if we use devnet, we have to deploy TON in L1
2.2 if we use live network, we should not deploy TON in L1
There was a problem hiding this comment.
Thank you!
I understood the context here.
I think using TON contract or ERC20 in oppenzeppelin are all good.
Using our TON contract maybe make user easier for testing since they can add some customized code.
LGTM!
theo-learner
force-pushed
the
OR-1276_setup-tokamak-packages
branch
from
040d57d
to
56c9b7a
Compare
Description
Set up the tokamak/sdk, tokamak/contracts-bedrock
Jira
https://onther.atlassian.net/browse/OR-1276