Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR-1409 add block period #76

Merged

Conversation

nguyenzung
Copy link
Member

Fix issue with newest geth by produce block for each 2 seconds.
The current mode will produce new blocks when there are new transactions.

Thank you!

Copy link
Member

@steven94kr steven94kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇🏻‍♂️
Do you know that there is installing geth logic?

@nguyenzung
Copy link
Member Author

Thank you! 🙇🏻‍♂️ Do you know that there is installing geth logic?

Do you mean "make install-geth" ?

@steven94kr
Copy link
Member

steven94kr commented Feb 26, 2024

Thank you! 🙇🏻‍♂️ Do you know that there is installing geth logic?

Do you mean "make install-geth" ?

Yes, when we make devnet-up, it is excuted as well!
So, if we use geth(installed by go) , I think we can resolve this issue!

@nguyenzung
Copy link
Member Author

Thank you! 🙇🏻‍♂️ Do you know that there is installing geth logic?

Do you mean "make install-geth" ?

Yes, when we make devnet-up, it is excuted as well! So, if we use geth(installed by go) , I think we can resolve this issue!

Yes, I tested it. It works perfectly.

Actually, "make install-geth" will install the version is noted in .gethrc. And the current version in .gethrc is an old version of Geth.
And I think we cannot run make devnet-up with latest version of geth.

@steven94kr
Copy link
Member

Thank you! 🙇🏻‍♂️ Do you know that there is installing geth logic?

Do you mean "make install-geth" ?

Yes, when we make devnet-up, it is excuted as well! So, if we use geth(installed by go) , I think we can resolve this issue!

Yes, I tested it. It works perfectly.

Actually, "make install-geth" will install the version is noted in .gethrc. And the current version in .gethrc is an old version of Geth.
And I think we cannot run make devnet-up with latest version of geth.

Yes, I agree with your valuable opinion. We may need to devnet up with the latest version of geth!
Thank you! 🙇🏻‍♂️

@nguyenzung nguyenzung merged commit 12c836c into main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants