This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Prevent owner address from being whitelisted #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nostdm
requested review from
hiddentao,
draganm,
asmckinlay and
i-stam
and removed request for
hiddentao
draganm
suggested changes
Aug 22, 2018
contracts/wallet.sol
Outdated
| @@ -104,6 +104,7 @@ contract Whitelist is Control { | |||
| require(!initializedWhitelist); | |||
| // Add each of the provided addresses to the whitelist. | |||
| for (uint i = 0; i < _addresses.length; i++) { | |||
| require(_addresses[i] != owner); | |||
There was a problem hiding this comment.
will probably burn a lot of gas if the last address is owner
There was a problem hiding this comment.
Good point - fixed with a modifier.
hiddentao
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #39