Feature/ui-photo fixed #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinn71
suggested changes
Sep 21, 2020
src/components/UiPhoto/FileField.vue
Outdated
|
|
||
| async validateFile (file) { | ||
| if (!this.isValidFileType(file)) { | ||
| this.$emit('error') |
There was a problem hiding this comment.
let's provide a prop with a handler for each. type of error. should be possible to do smth like:
<ui-photo
@err-invalid-file-size="someHandler"
@err-invalid-file-type="someAnotherHandler"
@err-invalid-file-dimensions="oneMoreHandler"
/>
src/components/UiPhoto/FileField.vue
Outdated
| labelMain: { type: String, default: 'Logo (Optional)' }, | ||
| labelTitle: { type: String, default: 'Drag a file here or click to browse' }, | ||
| labelFileName: { type: String, default: 'Selected file: ' }, | ||
| labelDraged: { type: String, default: 'Drag another file or click to browse' }, |
There was a problem hiding this comment.
use slots for placing text
src/components/UiText/index.vue
Outdated
| @@ -1,6 +1,10 @@ | |||
| <template> | |||
| <div class="ui-text" :for="inputId"> | |||
| <span class="ui-text__dock ui-text__dock_left" v-if="hasSlot('dock-left')"> | |||
| <div | |||
There was a problem hiding this comment.
I'll update ui-text component soon, so please rollback these changes to avoid conflicts on merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.