2838 20 no variables created note does not reflect actual created count #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
six7
reviewed
Jun 12, 2024
packages/tokens-studio-for-figma/src/plugin/createLocalVariablesInPlugin.ts
Show resolved
Hide resolved
six7
approved these changes
Jun 12, 2024
six7
deleted the
2838-20-no-variables-created-note-does-not-reflect-actual-created-count
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Current plugin only calculates the update variables which have references when creating variables.
Closes #2839
What does this pull request do?
Updated the calculating logic to calculate the newly created variables when creating variables.
Testing this change
Additional Notes (if any)
20240611_050843.mp4