Configure Commitlint #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to run more complex scripts and procedures it's easier to use husky own's sintax
yfernandes
force-pushed
the
gabi/atqr-32-configure-commitlint
branch
from
4d047d8
to
a406465
Compare
yfernandes
approved these changes
Apr 7, 2022
yfernandes
added a commit
that referenced
this pull request
Jul 27, 2022
* WIP payment-method created the main class and interface * HIP for saulos feedback * WIP payment-method for saulo's feedback * WIP EmailService started EmailService * WIP * WIP player * WIP logic of emailService * WIP * WIP changes in paymentMethod changed what saulo defined in his feedback * imported Guid from Toki Lang * updated visibility issues I have an error at lines 49 and 58 that i don`t understand * WIP player * WIP tryed to clean the EmailService code * WIP Player * WIP did the modifications pointed by Yago * Merges Challenge entity * WIP cleaning workspace * Cleaned workspace * Email service abstractions * Updades Api's tsconfig file * WIP Player * Scratch Api * Scratch Api * .env * Done with EmailService * Config module * Configuring Supabase with Prisma * Done with EmailSendding * WIP mailgun.service * Creates Challenge repository * Adds player to app module * commiit for Yago * Email service complete * WIP controller * Create Challenge Endpoint * Removes package-lock and wildcard dependencies. * Updates lib index and minor spelling mistake on player entity * WIP EmailService started EmailService * WIP * WIP logic of emailService * WIP * updated visibility issues I have an error at lines 49 and 58 that i don`t understand * WIP tryed to clean the EmailService code * WIP did the modifications pointed by Yago * WIP payment-method created the main class and interface * HIP for saulos feedback * WIP payment-method for saulo's feedback * WIP changes in paymentMethod changed what saulo defined in his feedback * imported Guid from Toki Lang * Merges Challenge entity * WIP cleaning workspace * Cleaned workspace * Email service abstractions * WIP Player * Updades Api's tsconfig file * Scratch Api * Scratch Api * .env * Done with EmailService * Done with EmailSendding * Config module * Configuring Supabase with Prisma * WIP mailgun.service * Creates Challenge repository * WIP controller * commiit for Yago * Adds player to app module * Email service complete * Create Challenge Endpoint * Removes package-lock and wildcard dependencies. * Challenge class (#1) * Creating the challenge class * fixing the constructor and the method changePaymentMethod * adding the get of the class * Simplyfing the constructor and changing the changePaymentMethod * trying to fix the changePaymentMethod Co-authored-by: Yago Fernandes <yagoalmeida@gmail.com> * Removes package-lock.json * WIP: ATQ-11 Creating challenge endpoint commit 168221a Author: Angelica <angelica@toki.life> Date: Fri Mar 25 15:33:38 2022 -0300 Implementation of error handling. # Conflicts: # libs/atqr/domain/src/lib/EmailService/email.interface.ts * WIP: Email Service commit cbdc0f9 Author: Gabriela Sanches <gabi@toki.life> Date: Fri Mar 25 15:43:15 2022 -0300 deleted old mailgun.service and did scope changes in IEmail, Email commit 3d9a63d Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:30:05 2022 -0300 did new mailer.service and changes in the .test file commit 4222913 Author: Gabriela Sanches <gabi@toki.life> Date: Wed Mar 23 13:12:01 2022 -0300 improved Mailer test commit 9aecf5b Author: Gabriela Sanches <gabi@toki.life> Date: Wed Mar 23 13:09:14 2022 -0300 installed Prisma, mailgun.js and @types/url-join commit 3d8afb5 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:29:49 2022 -0300 Commented lines and updated Mailer import to compile commit ee3de13 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Thu Mar 17 14:26:18 2022 -0300 Fix test to use the latest Mailgun Service, and fixes Test errors commit a2a4fe2 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Thu Mar 17 14:25:54 2022 -0300 Creates parameter for test mode on onAplicationBootstrap commit 46c1a7c Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Thu Mar 17 14:25:01 2022 -0300 Updates Workspace to fix api targets commit 42a9939 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Thu Mar 17 14:24:27 2022 -0300 Updates Package.Json and lockfiles commit b4081d4 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Tue Mar 15 11:42:15 2022 -0300 Migrates Mailgun service and test to Async/Await Syntax commit 9f5904f Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:28:52 2022 -0300 mailgun testing for yago to check erros commit 1c36ac2 Author: Gabriela Sanches <gabi@toki.life> Date: Tue Mar 8 10:48:44 2022 -0300 Tested mailgun Service and generated coverage page commit 8778004 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:28:17 2022 -0300 Working Mailer test, super basic implementation # Conflicts: # apps/atqr/api/src/app/infra/email/mailgun.service.test.ts # libs/atqr/domain/src/lib/EmailService/email.interface.ts # libs/atqr/domain/src/lib/EmailService/index.ts # libs/atqr/domain/src/lib/challenge-entity.ts commit 0b5f6a7 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:28:05 2022 -0300 reorganized Mail class and started testing wthJest commit 562fe97 Author: Gabriela Sanches <gabi@toki.life> Date: Thu Feb 24 14:08:51 2022 -0300 finished mailgun structure and created .test file commit 54ac1a7 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Thu Feb 24 13:01:20 2022 -0300 Adds Jest testing on NX Workspace API commit 2cd6c79 Author: Gabriela Sanches <gabi@toki.life> Date: Wed Feb 23 13:45:24 2022 -0300 cleaned up email-service code commit 23a4aa3 Author: Gabriela Sanches <gabi@toki.life> Date: Tue Feb 22 16:41:04 2022 -0300 organizing mailgun service commit 8c2a126 Author: Gabriela Sanches <gabi@toki.life> Date: Tue Feb 22 14:40:52 2022 -0300 did some config with yago to resolve import errors commit dd658af Author: Gabriela Sanches <gabi@toki.life> Date: Sat Jan 29 17:04:24 2022 -0300 WIP yago did some changes * WIP: Challenge Entity commit 71e56ff Author: Raquel <raquel@toki.life> Date: Thu Mar 24 17:14:13 2022 -0300 creating the tests of the class challenge commit fda2152 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:38:27 2022 -0300 Fixing the duplication of the doc challenge-entity and the class challenge # Conflicts: # libs/atqr/domain/src/lib/challeng-entity.ts commit 27398a9 Author: Raquel <raquel@toki.life> Date: Sat Jan 29 17:07:10 2022 -0300 trying to fix the changePaymentMethod commit 0080412 Author: Raquel <raquel@toki.life> Date: Sat Jan 29 15:51:26 2022 -0300 Simplyfing the constructor and changing the changePaymentMethod # Conflicts: # package-lock.json commit 5a43382 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:36:59 2022 -0300 adding the get of the class # Conflicts: # .vscode/settings.json # libs/atqr/domain/src/lib/challeng-entity.ts # package-lock.json # package.json # yarn.lock commit c2f7bae Author: Raquel <raquel@toki.life> Date: Tue Jan 25 09:27:41 2022 -0300 fixing the constructor and the method changePaymentMethod # Conflicts: # libs/atqr/domain/src/lib/challeng-entity.ts # package-lock.json # package.json # yarn.lock commit a075b96 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:36:41 2022 -0300 Creating the challenge class # Conflicts: # libs/atqr/domain/src/lib/challeng-entity.ts # package.json # yarn.lock * WIP: Deadline Monitor Service commit e78add6 Author: Raquel <raquel@toki.life> Date: Mon Feb 7 09:24:57 2022 -0300 WIP creating the class monitordeadline service commit 6c14d5b Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 16:43:41 2022 -0300 Creating the Challenge Class # Conflicts: # .vscode/settings.json # package-lock.json # package.json # yarn.lock commit 9dc9747 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 17:38:34 2022 -0300 Validating the minimum amount of the price and fixing the changePaymentMethod # Conflicts: # libs/atqr/domain/src/lib/challenge-entity.ts commit ad66ec9 Author: Raquel <raquel@toki.life> Date: Tue Jan 25 09:27:41 2022 -0300 fixing the constructor and the method changePaymentMethod # Conflicts: # libs/atqr/domain/src/lib/challeng-entity.ts # package-lock.json # package.json # yarn.lock commit 5ea2602 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 17:37:52 2022 -0300 Creating the challenge class # Conflicts: # libs/atqr/domain/src/lib/challeng-entity.ts # package.json # yarn.lock * WIP: ATQR-29 Stripe Payment Service commit d67cff2 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Wed Feb 23 11:12:00 2022 -0300 Stripe Service configuration commit 2d4b545 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 17:18:24 2022 -0300 Adds stripe lib depedency * WIP: Updates ATQ-22 squash commit commit 0c704df Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 17:49:04 2022 -0300 fixing the constructor and the method changePaymentMethod # Conflicts: # libs/atqr/domain/src/lib/challeng-entity.ts # package-lock.json # package.json # yarn.lock * WIP: Finishes Squashing Email Service Branch commit 8713ae4 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 18:07:21 2022 -0300 Updates Package.Json and lockfiles commit 7745c9a Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 18:05:47 2022 -0300 finished mailgun structure and created .test file commit b6cf066 Author: Yago Fernandes <yagoalmeida@gmail.com> Date: Fri Apr 1 18:04:22 2022 -0300 did some config with yago to resolve import errors * Configures Commitlint (#6) * chore: add commitlint e husky * feat: configured commitlint * feat: allow husky to be used automatic with commit * feat: allow commit automaticly with husky * feat(commitzen): migrates from pkg.json based config to husky own folder In order to run more complex scripts and procedures it's easier to use husky own's sintax Co-authored-by: Yago Fernandes <yagoalmeida@gmail.com> * Creates web app for ATQR * fix(removes boilerplate): removes auto-generated boilerplate from @nrwl/web generated project * Domain challenge entity (#9) * testing and improve challenge class * Testing and improving the challenge class * Delete deadline-monitor-service.ts * Delete deadline-interface.ts * Fix the errors pointing in the code review * refactor(challenge-entity): moves and renames files for consistency and ease of use * style(challenge.entity): fixes typos Co-authored-by: Yago F <yagoalmeida@gmail.com> * Test: Add tests for the class Player (#10) * Test: Add tests in the class Player * Code review fixes Co-authored-by: Saulo Vallory <saulo@toki.life> * Challenges Service (#12) - The famous branch 42 * testing and improve challenge class * Testing and improving the challenge class * Fix the errors pointing in the code review * feat: created challenge-entity.controller and started implementation updated the app.controller * feat: Added a player propriety to deal with mistakes in challenge repository * chore: config changes to enable experimental decorators * feat: fineshed implementing FindLastChallenges issue on backend * feat(class-transformer): adds class-transformer dep to hydrate entities * feat(app.module): adds challenge controller to app.module * feat(repositories): hydrates prisma entities before returning * fix(style and linting): applies formatting to controllers and entities and minor fixes * fix(.gitignore): fixes git ignore and removes .env * chore: added new version of prisma * refactor: deleted unnecessary files * feat: did a migration * feat: added id and paymentMethod props and their types * feat: changed price type on prisma schema * fix: spelling mistakes and imported Get on challenge repo * feat: imported Mailer on the "providers" on AppModule * feat: cherry-picked challenge-entity.controller * [WIP] Handing off fixes to @yfernandes * chore(todo-tree): adds Todo-Tree extension recomendation and settings * refactor(linting): basic Linting on domain * refactor(prisma.schema): autoformats prisma.schema * feat(migration): adds migration for updating challenge status * fix(prisma.schema): renames challenge to challenges * fix(eslint.rc): fixes .eslintrc.json path * chore(app.controller): deletes empty app.controller * chore(challenge controller): renames challenge-entity.controller to challenge.controller * feat(challenge.entity): adds static enumeration to ChallengeStatus enum * fix(challenge.repository): updates import paths and fixes status type * refactor(api): lints and applies minor refactoring api wide Co-authored-by: Yago Fernandes <yagoalmeida@gmail.com> * feat(prisma): upgrades to prisma version 4.1 * Email service (#3) * talcoisa * fix(mailer): removes unused config file. The correct config module is elsewhere The file was created mistakenly and was removed * test(mailer.service): scratch implementation of error handling based on Mailgun Status code Base implementation for handling error status returned by mailgun * test(mailer.service.test): implemented mock version of Mailgun's message client Spies on and mocks mailgun.client.message.create and finalizes mailer.service.test base implementation. Only 1 error code from Mailgun is being handled for now * style(mailer test): renames Mailer.service.test * talcoisa * cleaned up/ organized code from EmailService perspective * style: changes pointed by Saulo in pull request * refactor(mailer.service.test): removes copy of Mailgun error interface * refactor(emailaddress): renames ands exports EmailAddress value object from lib * refactor(domain lib): updates imports that got broken on PaymentMethodEntity renaming * test(mailer.service.test): removes unhelpfull tests and cleans imports * refactor(api): minor refactor and linting Co-authored-by: Yago F <yagoalmeida@gmail.com> * Create DeadlineMonitorService (#16) * Little changes in the logic in the deadline monitor * Improving DeadlineMonitorService and Connecting with the database * refactor: cut and clean the code * Little changes in the logic in the deadline monitor * Improving DeadlineMonitorService and Connecting with the database * refactor: cut and clean the code * [WIP] Handing over to Raquel * refactor(deadline monitor - challenge class - challenge repository): implement deadline monitor * feat(domain index): creates and updates Index files * feat(cron): adds cron @types * fix(project wide): updates imports and paths * refactor(project wide): minor housekeeping refactoring in a few files in the domain and api * feat(app module): creates factory for deadline monitor and notification services Co-authored-by: Yago Fernandes <yagoalmeida@gmail.com> Co-authored-by: Saulo Vallory <saulo@toki.life> * testing and improve challenge class * Testing and improving the challenge class * Fix the errors pointing in the code review * feat: created challenge-entity.controller and started implementation updated the app.controller * feat: Added a player propriety to deal with mistakes in challenge repository * chore: config changes to enable experimental decorators * feat: fineshed implementing FindLastChallenges issue on backend * feat(class-transformer): adds class-transformer dep to hydrate entities * feat(app.module): adds challenge controller to app.module * feat(repositories): hydrates prisma entities before returning * fix(style and linting): applies formatting to controllers and entities and minor fixes * chore: added new version of prisma * refactor: deleted unnecessary files * feat: did a migration * feat: added id and paymentMethod props and their types * feat: changed price type on prisma schema * fix: spelling mistakes and imported Get on challenge repo * feat: imported Mailer on the "providers" on AppModule * feat: cherry-picked challenge-entity.controller * [WIP] Handing off fixes to @yfernandes * refactor(linting): basic Linting on domain * fix(prisma.schema): renames challenge to challenges * chore(challenge controller): renames challenge-entity.controller to challenge.controller * feat(challenge.entity): adds static enumeration to ChallengeStatus enum * fix(challenge.repository): updates import paths and fixes status type * feat(stripe): scratch implementation * chore(stripe.controller): cleanup. Removes unnecessary imports and formating * feat(main.ts): adds raw body decorator for entire api The webhook verification method requires the raw event body to sum check. The built in body parser was disabled and a new one with the option for raw body was implemented * feat(stripe.module): adds Stripe.module to app * feat(stripe.controller): adds webhook event handling * feat(prisma): updates prisma client to version 4.0.0 * feat(env.example): adds webhook secret to env.example Co-authored-by: Gabriela Sanches <gabi@toki.life> Co-authored-by: Angelica <angelica@toki.life> Co-authored-by: Raquel <raquel@toki.life> Co-authored-by: Gabriela Sanches <86623626+GabrielaRsanches@users.noreply.github.com> Co-authored-by: Angélica Chagas <80177921+angeliralves@users.noreply.github.com> Co-authored-by: Saulo Vallory <saulo@toki.life>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration of commitlint using husky and commitizen