Show popular goals #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the most used goals
withdrew the function group by goal
raquellenn
changed the base branch from
development
to
saulo/domain-definition-disl
svallory
reviewed
Dec 21, 2022
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
svallory
reviewed
Dec 21, 2022
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
svallory
reviewed
Dec 21, 2022
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
svallory
requested changes
Dec 22, 2022
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
Comment on lines
5
to
12
| Repository | ||
| showPopularGoals? :qty | ||
|
|
||
| find challenges with the same goal and group them in a arrayNameGoal | ||
| for each arrayNameGoal count the lenght | ||
| order the arrayNameGoal by descending lenght of the array | ||
|
|
||
| then return :qty Goals |
There was a problem hiding this comment.
This should be inside the context. Also...
- What is the name of the repository?
- Repositories do not handle commands. You need a service for this command since it manipulates many instances
- You'll still need a repository with a method that has a similar name and does the actual query
There was a problem hiding this comment.
I dont know if a get it...do you want me to write the repository in this file ?
|
Kudos, SonarCloud Quality Gate passed!
|
yfernandes
force-pushed
the
saulo/domain-definition-disl
branch
from
67cf709
to
f1edc59
Compare
|
Merged via #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storie in disl for see the most popular goals
link for storie in notion:
https://www.notion.so/tokinetwork/12e66733aa6b48a9a79bff76139e4cfa?v=45d79c3db5de45cdac0bdcaec8f62b58&p=135e1a71599a4faebf94ee76101c660c&pm=s