-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show popular goals #63
Conversation
…the most used goals
withdrew the function group by goal
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
libs/atqr/domain/src/lib/domain-spec/stories/showPopularGoals.disl
Outdated
Show resolved
Hide resolved
Repository | ||
showPopularGoals? :qty | ||
|
||
find challenges with the same goal and group them in a arrayNameGoal | ||
for each arrayNameGoal count the lenght | ||
order the arrayNameGoal by descending lenght of the array | ||
|
||
then return :qty Goals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be inside the context. Also...
- What is the name of the repository?
- Repositories do not handle commands. You need a service for this command since it manipulates many instances
- You'll still need a repository with a method that has a similar name and does the actual query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know if a get it...do you want me to write the repository in this file ?
Kudos, SonarCloud Quality Gate passed! |
67cf709
to
f1edc59
Compare
Merged via #69 |
storie in disl for see the most popular goals
link for storie in notion:
https://www.notion.so/tokinetwork/12e66733aa6b48a9a79bff76139e4cfa?v=45d79c3db5de45cdac0bdcaec8f62b58&p=135e1a71599a4faebf94ee76101c660c&pm=s