Create notifications value objects #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielaRsanches
requested review from
a team and
albnunes
and removed request for
a team
svallory
changed the title
GabrielaRsanches
force-pushed
the
ATQR-79-Create-Notifications-Value-Objects
branch
from
5f384b5
to
7149449
Compare
svallory
requested changes
Jan 27, 2023
libs/atqr/domain/src/lib/valueObjects/notificationLogEntry.valueObject.ts
Outdated
Show resolved
Hide resolved
svallory
reviewed
Jan 27, 2023
New Value Objects can exclude properties when comparing identity (e.g. `id`) by adding the string "id" to `excludeFromEquals` inside its constructor
svallory
reviewed
Jan 30, 2023
svallory
reviewed
Jan 30, 2023
libs/atqr/domain/src/lib/valueObjects/notificationLogEntry.valueObject.ts
Outdated
Show resolved
Hide resolved
svallory
reviewed
Jan 30, 2023
libs/atqr/domain/src/lib/valueObjects/notificationLogEntry.valueObject.ts
Outdated
Show resolved
Hide resolved
svallory
reviewed
Jan 30, 2023
svallory
approved these changes
Jan 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
GabrielaRsanches
added a commit
that referenced
this pull request
Jan 31, 2023
* refactor(valueobject.ts): vO is now updated with documentation details * refactor(notification vos): all notification VOs except TemplateDataType * style(email templates): all email templates are now in "lib/templates/email.ts" n * refactor(notification value objects): notification VO's and concept are updated * docs(notification.ts): comments on calculated props * feat(utils): ✨ add ability to exclude props from ValueObject.equals New Value Objects can exclude properties when comparing identity (e.g. `id`) by adding the string "id" to `excludeFromEquals` inside its constructor * refactor(notification vo's): hash is been used as id * refactor(emailtemplates): emailTemplates folder was retored --------- Co-authored-by: Saulo Vallory <saulo@toki.life>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForbiddenEmailAddress, Notification and NotificationLogEntry VO's are implemented and email templates are now in lib/templates/email . This change in folders were made to correctly import EmailAddress where it is needed