Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create notifications value objects #93

Merged
merged 8 commits into from
Jan 30, 2023

Conversation

GabrielaRsanches
Copy link
Contributor

ForbiddenEmailAddress, Notification and NotificationLogEntry VO's are implemented and email templates are now in lib/templates/email . This change in folders were made to correctly import EmailAddress where it is needed

@GabrielaRsanches GabrielaRsanches self-assigned this Jan 26, 2023
@GabrielaRsanches GabrielaRsanches requested review from a team and albnunes and removed request for a team January 26, 2023 18:07
@svallory svallory changed the title Atqr 79 create notifications value objects Create notifications value objects Jan 26, 2023
@GabrielaRsanches GabrielaRsanches force-pushed the ATQR-79-Create-Notifications-Value-Objects branch from 5f384b5 to 7149449 Compare January 27, 2023 15:14
Copy link
Member

@svallory svallory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove file suffixes like .types and .valueObject. Although it has a lot of comments, this is a good PR! It's definitely a step up from previous ones. Congrats! :D

libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/types/notification.types.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/types/notification.types.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
Copy link
Member

@albnunes albnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the comments

libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
albnunes
albnunes previously approved these changes Jan 30, 2023
Copy link
Member

@albnunes albnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for one last review.

libs/atqr/domain/src/lib/valueObjects/notification.ts Outdated Show resolved Hide resolved
New Value Objects can exclude properties when comparing identity (e.g. `id`) by adding the string "id" to `excludeFromEquals` inside its constructor
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@svallory svallory merged commit fb16a67 into development Jan 30, 2023
GabrielaRsanches added a commit that referenced this pull request Jan 31, 2023
* refactor(valueobject.ts): vO is now updated with documentation details

* refactor(notification vos): all notification VOs except TemplateDataType

* style(email templates): all email templates are now in "lib/templates/email.ts"

n

* refactor(notification value objects): notification VO's and concept are updated

* docs(notification.ts): comments on calculated props

* feat(utils): ✨ add ability to exclude props from ValueObject.equals

New Value Objects can exclude properties when comparing identity (e.g. `id`) by adding the string "id" to `excludeFromEquals` inside its constructor

* refactor(notification vo's): hash is been used as id

* refactor(emailtemplates): emailTemplates folder was retored

---------

Co-authored-by: Saulo Vallory <saulo@toki.life>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants