Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make IntoIter constructor public #581

Merged
merged 1 commit into from Nov 25, 2022
Merged

make IntoIter constructor public #581

merged 1 commit into from Nov 25, 2022

Conversation

matko
Copy link
Contributor

@matko matko commented Nov 25, 2022

This PR makes the constructor of IntoIter public, so that it can be used with arbitrary Buf implementations.

Fixes #580.

Darksonn
Darksonn approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Darksonn Darksonn merged commit 050d65b into tokio-rs:master Nov 25, 2022
lelongg pushed a commit to lelongg/bytes that referenced this pull request Jan 9, 2023
@matko @lelongg
make IntoIter constructor public (tokio-rs#581)
82cc99f
@Darksonn Darksonn mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iter() is missing on Buf
2 participants
@matko @Darksonn