Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize refactor #696

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Resize refactor #696

merged 8 commits into from
Apr 24, 2024

Commits on Apr 21, 2024

  1. use checked_sub

    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    22dd583 View commit details
    Browse the repository at this point in the history

  2. return when additional == 0

    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    dffdeaf View commit details
    Browse the repository at this point in the history

  3. move safe operation out of unsafe block

    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    f247f2d View commit details
    Browse the repository at this point in the history

  4. use spare_capacity_mut instead of chunk_mut 

    We don't need to check capacity because it's already been reserved
above.
    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    8a62462 View commit details
    Browse the repository at this point in the history

  5. Add safety comments

    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    0096b25 View commit details
    Browse the repository at this point in the history

  6. refactor to use guard clauses 

    This would be better written with let-else, but we won't get that until
`MSRV >= 1.65.x`.
    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    a1d0cc6 View commit details
    Browse the repository at this point in the history

  7. use if-let instead of unwrap

    @braddunbar
    braddunbar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    63bca89 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. reduce scope of unsafe blocks 

    Co-authored-by: Alice Ryhl <aliceryhl@google.com>
    @braddunbar @Darksonn
    braddunbar and Darksonn authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    434166a View commit details
    Browse the repository at this point in the history