Add from_std methods to TCP/Unix Stream/Listener #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleimkuhler
changed the title
|
Can't this be implemented using |
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
kleimkuhler
force-pushed
the
kleimkuhler/listener-from-std
branch
from
9210f25
to
ae6a33f
Compare
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
|
@Thomasdezeeuw It's not critical to merge this, but IMO it is valuable to have an API for going from std -> mio in a portable way. Requiring going via raw conversions would require platform specific code. |
Thomasdezeeuw
requested changes
Nov 7, 2019
carllerche
reviewed
Nov 7, 2019
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
|
@Thomasdezeeuw Thanks for the review. All your comments have been addressed. I added a lot more around tests; each I/O resource now have tests that test the |
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
Thomasdezeeuw
approved these changes
Nov 8, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1029 removed the
from_stdmethods on the TCP (Unix) Stream (Listener)resources. These methods are still needed in upstream libraries where creating
wrapped resources from standard types is needed.
Tokio: TcpListener::from_std
Signed-off-by: Kevin Leimkuhler kleimkuhler@icloud.com