Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various test clean ups #1145

Merged
merged 9 commits into from
Nov 23, 2019
Merged

Various test clean ups #1145

merged 9 commits into from
Nov 23, 2019

Commits on Nov 22, 2019

  1. Remove assert_ok macro from test utils 

    The unwrap function has the same effect.
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    d0bd954 View commit details
    Browse the repository at this point in the history

  2. Remove assert_err macro from test utils 

    The unwrap_err function has the same effect.
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    73cc2f5 View commit details
    Browse the repository at this point in the history

  3. Add Readiness type to test utilities 

    Used in the ExpectEvent structure.
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    1c92c0b View commit details
    Browse the repository at this point in the history

  4. Replace expect_readiness macro with expect_events 

    Removing expect_readiness completely. It didn't use the token so it was
unclear what event should have read/write closed indicators.
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    eda2b34 View commit details
    Browse the repository at this point in the history

  5. Remote TryWrite and TryRead traits from test utilies 

    This also removes the echo_server test from the tcp module. All
functionality is tested elsewhere and this test is just too complex to
attempt to fix (it used the TryRead and TryWrite traits).
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    a88506d View commit details
    Browse the repository at this point in the history

  6. Remove slab as test dependency

    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    88e31d8 View commit details
    Browse the repository at this point in the history

  7. Replace Byte with Vec in close_on_drop test

    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    f49f315 View commit details
    Browse the repository at this point in the history

  8. Add checked_write macro the test utilities 

    Some places checked the return value after a write, but all. This ensure
that all write, send and send_to calls check the return value.
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    892f856 View commit details
    Browse the repository at this point in the history

  9. Add expect_read test macro 

    Testing macro that calls read/recv/peek or recv_from/peek_from and
checks if the received bytes are expected. In case of {recv,peek}_from
it also checks the source address.
    @Thomasdezeeuw
    Thomasdezeeuw committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    9025e98 View commit details
    Browse the repository at this point in the history