Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FD_CLOEXEC flag on duplicated kqueue Poll #1498

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Set FD_CLOEXEC flag on duplicated kqueue Poll #1498

merged 2 commits into from
Jun 14, 2021

Commits on Jun 12, 2021

  1. Set FD_CLOEXEC flag on duplicated kqueue Poll 

    Same as commit c52635c, but for kqueue.
    @Thomasdezeeuw
    Thomasdezeeuw committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    d3ca7e6 View commit details
    Browse the repository at this point in the history

  2. Fix Selector::try_clone 

    Calls fcntl F_DUPFD_CLOEXEC expects two arguments; the command
(F_DUPFD_CLOEXEC) and an argument for the command. In this case an lower
bound for the resulting file descriptor. Because we didn't provide a
value it would take whatever value was left in the register from
whatever code used it before the system call.

This caused Waker::new to fail, see issue
tokio-rs#1497.
    @Thomasdezeeuw
    Thomasdezeeuw committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    f873406 View commit details
    Browse the repository at this point in the history