Implements ReadHint for Hup for Linux #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HupHint, | ||
| ErrorHint, | ||
| UnknownHint | ||
| } |
There was a problem hiding this comment.
This should probably be bitflags since there can be multiple available states, for example data + hup?
This implements the first part of the strategy outlined in #4. Closes #4. It updates the tests to take the read hint in the handlers, and specifically confirm that they get the DataHint first and then the HupHint. I believe that the hints are implementable on all of the backends we intend to support, so I consider it a bug if those tests don't pass on a supported platform. Note that this information is called a "hint" because you still need to handle errors in your read handler, but this may allow you to skip the extra `read` syscall as an optimization.
wycats
force-pushed
the
read_hint_take2
branch
from
374cfea
to
666e887
Compare
|
Resolved by 9a072b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first part of the strategy outlined in #4.
It updates the tests to take the read hint in the handlers, and
specifically confirm that they get the DataHint first and then the
HupHint.
I believe that the hints are implementable on all of the backends we
intend to support, so I consider it a bug if those tests don't pass on a
supported platform.
Note that this information is called a "hint" because you still need to
handle errors in your read handler, but this may allow you to skip the
extra
readsyscall as an optimization.This PR supersedes #5.