First whack at UDP send/receive sockets for Mio #35
Conversation
|
Hopefully Travis will pass when pull request nix-rust/nix#12 is merged in. However, this pull request now includes support for recvfrom/sendto to maximize usefulness of UDP sockets. |
|
I'm restarting the travis build. I will try to review the PR tonight! |
|
I looked over the patch. Seems like a good start. I am going to bike shed it some but I am not super familiar w/ UDP so I may say some dumb things. Also, it looks like the travis fail was due to a change in the Rust stdlib. I fixed master. |
|
|
||
|
|
||
| // Unconnected socket sender -- trait unique to sockets | ||
| pub trait IoUnconnectedSender { |
There was a problem hiding this comment.
Are there any other uses for these two traits besides for UDP sockets? It seems like it will probably be better to keep these traits mio::net::udp unless there are other use cases.
There was a problem hiding this comment.
Good question -- the rationale I had for splitting these out was actually related to UNIX domain sockets. When you have multiple potential clients to a single "listening" UNIX domain socket, you need to use recvfrom/sendto to make sure your message gets to the right destination. Thus, you could treat AF_UNIX sockets like AF_INET[6], SOCK_DGRAM sockets. This also helps for AF_RAW sockets and such, but I'd be surprised if anyone went that far. My thought was that there could be applications that are exclusively directed datagram oriented, so an AF_UNIX, and UDP socket could implement the same traits.
There was a problem hiding this comment.
Interesting, but it's only sockets then? So maybe the trait can be UnboundSocket in net.rs? Also, does it make sense to split it up into 2 traits vs. a single UnboundSocket? As in, can there be a reader w/o a writer or the other way around?
If you can do this and rebase, I can merge into master (assuming all tests pass of course :)). Any further tweaks can happen on the main branch.
|
Overall it looks pretty good. My main thought would be to not bother w/ Alternatively, have UdpSocket be a trait that implements |
Add support to mio for listening and managing UDP sockets, including infrastructure for supporting unconnected sockets (i.e. using recvfrom/sendto) and appropriate interfaces to be exposed for connectionless sockets. Additionally, adds support for multicast listener/transmitter sockets.
|
Cool, I just made the change to the UnconnectedSocket trait (and moved it to net.rs) -- I think that's a much cleaner approach to the API, and it's unlikely you'll have a case where you'll only want sendto OR recvfrom. Let me know if you have any suggestions or feedback! |
|
Looks good to me. I'll merge it. Do you mind if I rebase into 1 commit? I can keep the author info 👍 |
|
Damnit, I thought I did rebase it into one commit -- but yeah, definitely OK by me. |
Add initial support to MIO for UDP sockets, including the ability to
join multicast groups and listen. Still need to add support for
recvfrom/sendto, but works just fine for connected UDP sockets.
Depends on nix-rust having pull request nix-rust/nix#12