Fixed looping timer #497
Closed
Fixed looping timer #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, just wondering if the mio team has seen this at all? I really don't like to maintain alternative forks of repos for parity which is why I'm trying to upstream this fix. Any response would be appreciated. |
arthurprs
reviewed
Dec 7, 2016
| trace!("tick_to; target_tick={}; current_tick={}", target_tick, self.tick); | ||
|
|
||
| if target_tick < self.tick { |
|
LGTM but I wonder if this is band aiding it instead of fixing the root cause. Edit: from a quick glance this should only happen if the clock drifts back, which shouldn't be possible using |
timer: fix indentation
|
Ah sorry this slipped under the radar! I merged this as ef182ba and did a whitespace fixup last night, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling the patch described in https://github.com/ethcore/parity/pull/3592 upstream.