Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export os::IoDesc under io::IoDesc. #79

Merged
merged 1 commit into from
Dec 29, 2014

Conversation

reem
Copy link
Contributor

@reem reem commented Dec 26, 2014

I've been trying to implement IoHandle for some convenience
wrappers.

@carllerche
Copy link
Member

I'm good w/ re-exporting IoDesc but IoDesc should not be clone (since the Fd can be closed from one of the clones). It should be duped in the case of posix at least.

@rrichardson
Copy link
Contributor

If you need to reference connections from many places, I'd recommend the
Token in a Slab model. If you need to use the actual connection from
multiple threads, I'd say something has gone wrong.

On Mon Dec 29 2014 at 12:58:36 PM Carl Lerche notifications@github.com
wrote:

I'm good w/ re-exporting IoDesc but IoDesc should not be clone (since the
Fd can be closed from one of the clones). It should be duped in the case of
posix at least.


Reply to this email directly or view it on GitHub
#79 (comment).

@reem
Copy link
Contributor Author

reem commented Dec 29, 2014

I needed this to just work around some simple ownership headaches, but I figured out a different solution.

Updated the PR to remove the Clone commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants