Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo bench --workspace fails #1005

Closed
zamazan4ik opened this issue Mar 17, 2024 · 0 comments · Fixed by #1037
Closed

cargo bench --workspace fails #1005

zamazan4ik opened this issue Mar 17, 2024 · 0 comments · Fixed by #1037

Comments

@zamazan4ik
Copy link

Hi!

When I run cargo bench --workspace I get the following error:

     Running benches/dataset.rs (target/release/deps/dataset-0a8d39c13ac4bd81)
dataset/google_message1_proto2/merge
                        time:   [250.38 ns 250.45 ns 250.52 ns]
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
dataset/google_message1_proto2/encode
                        time:   [146.97 ns 147.85 ns 148.76 ns]
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
dataset/google_message1_proto2/encoded_len
                        time:   [36.920 ns 36.921 ns 36.923 ns]
Found 8 outliers among 100 measurements (8.00%)
  1 (1.00%) low mild
  6 (6.00%) high mild
  1 (1.00%) high severe

dataset/google_message1_proto3/merge
                        time:   [196.32 ns 196.54 ns 196.74 ns]
dataset/google_message1_proto3/encode
                        time:   [133.52 ns 133.86 ns 134.19 ns]
dataset/google_message1_proto3/encoded_len
                        time:   [32.852 ns 32.857 ns 32.862 ns]
Found 16 outliers among 100 measurements (16.00%)
  2 (2.00%) high mild
  14 (14.00%) high severe

dataset/google_message2/merge
                        time:   [137.10 µs 137.16 µs 137.24 µs]
dataset/google_message2/encode
                        time:   [54.481 µs 54.501 µs 54.520 µs]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
dataset/google_message2/encoded_len
                        time:   [12.244 µs 12.246 µs 12.249 µs]
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

Benchmarking dataset/google_message3_1/merge: Warming up for 3.0000 sthread 'main' panicked at protobuf/benches/dataset.rs:29:45:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed, to rerun pass `-p protobuf --bench dataset`

Expected behaviour: the benchmark runs without errors.

prost version: master branch, 2a4aeafa31dddbfe7d8dd7915c561f95ef45ec93 commit
Rustc version: 1.76

caspermeijn added a commit to caspermeijn/prost that referenced this issue Apr 22, 2024
The dataset for these benchmarks are not distributed in upstream protobuf. Therefore they fail when running `cargo bench --workspace`.

Fixes tokio-rs#1005

Open question:
- Are these datasets available for download? If yes, we could add them to the repo.
caspermeijn added a commit to caspermeijn/prost that referenced this issue Apr 22, 2024
The dataset for these benchmarks are not distributed in upstream protobuf. Therefore they fail when running `cargo bench --workspace`.

Fixes tokio-rs#1005

Open question:
- Are these datasets available for download? If yes, we could add them to the repo.
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
The dataset for these benchmarks are not distributed in upstream protobuf. Therefore they fail when running `cargo bench --workspace`.

Fixes #1005

Open question:
- Are these datasets available for download? If yes, we could add them to the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant