Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Introduces
And provides an implementation for all Ops (there are a lot aren't there?).
Where an Op is
Op<OP_HERE,_>
. This makes a lot of sense, as the structs already contained all (or most) of the data required to create the Op itself.What this PR doesn't do is expose them, it just puts the framework in place. Tests still pass, and Benchmarks improve fractionally, seemingly due to better L1 cache hits. Haven't looked into, and not that interested in why.
Future PR's can go several ways from here.
For the sake of clarity, this doesn't introduce Deferred Ops, which is a seperate concern. It doesn't block it either.
d as draft because I expect significant discussion