net: UDP socket gets local_addr, read_fixed and write_fixed #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Noah-Kennedy Can you review? The additions are innocuous. I'll do a separate sweep of all the code and change functions to use the socket2::SockRef::from call in a separate PR. |
Noah-Kennedy
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type UdpSocket gets methods local_addr, read_fixed and write_fixed.
local_addr is useful when binding the socket to 127.0.0.1:0 to be able to report what port the OS assigned.
The read_fixed and write_fixed are useful, like read and write, when the UDP socket has been connected to an address.