Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: reconsider OS specific Ext traits #2925

Closed
carllerche opened this issue Oct 8, 2020 · 0 comments · Fixed by #3264
Closed

meta: reconsider OS specific Ext traits #2925

carllerche opened this issue Oct 8, 2020 · 0 comments · Fixed by #3264
Assignees
@carllerche
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request.
Milestone
v1.0

Comments

@carllerche
Copy link
Member

Currently, the fs module uses extension traits to add functionality only available on some operating-systems. There has been some discussion in the past questioning whether this is the right direction.

Tokio should decide if std should be copied in this case or learn from std's experience. The alternative would be to add the functions directly on the types but guarded with operating system cfg flags.
@carllerche carllerche added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Oct 8, 2020
@carllerche carllerche added this to the v1.0 milestone Oct 8, 2020
@carllerche carllerche self-assigned this Dec 12, 2020
carllerche added a commit that referenced this issue Dec 12, 2020
@carllerche
fs: use cfgs on fns instead of OS ext traits
c43552b 
Instead of using OS specific extension traits, OS specific methods are
moved onto the structs themselves and guarded with `cfg`. The API
documentation should highlight the function is platform specific.

Closes #2925
@carllerche carllerche mentioned this issue Dec 12, 2020
Merged
carllerche added a commit that referenced this issue Dec 14, 2020
@carllerche
fs: use cfgs on fns instead of OS ext traits (#3264)
3f29212 
Instead of using OS specific extension traits, OS specific methods are
moved onto the structs themselves and guarded with `cfg`. The API
documentation should highlight the function is platform specific.

Closes #2925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carllerche carllerche

Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request.
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

fs: use cfgs on fns instead of OS ext traits tokio-rs/tokio
1 participant
@carllerche