Lio3 #142
Merged
Lio3 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
requested changes
Feb 19, 2018
src/reactor/poll_evented.rs
Outdated
| @@ -17,6 +17,12 @@ use tokio_io::{AsyncRead, AsyncWrite}; | |||
|
|
|||
| use reactor::{Handle, Direction}; | |||
|
|
|||
| struct PollEventedInner { | |||
There was a problem hiding this comment.
I've been meaning to make this change.
Would you mind renaming this struct to Registration and updating the PollEvented field name to registration as well?
| @@ -292,6 +298,11 @@ impl<E> PollEvented<E> { | |||
| &mut self.io | |||
| } | |||
|
|
|||
| /// Consumes the `PollEvented` and returns the underlying I/O object | |||
There was a problem hiding this comment.
I think naming this into_inner would be more idiomatic.
FreeBSD uses a separate kqueue filter type for lio_listio. This change adds support for that filter type. Full functionality will be provided by the mio-aio and tokio-file crates.
Consumes a PollEvented and returns its inner io object. Useful for io types that have exclusive ownership of a resource.
|
Rebased. |
carllerche
approved these changes
Feb 26, 2018
This was referenced Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tokio to work with
lio_listio.See also tokio-rs/tokio-core#302