-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for inspecting JoinErrors #2051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
reviewed
Jan 7, 2020
carllerche
reviewed
Jan 7, 2020
carllerche
reviewed
Jan 7, 2020
Thoughts @seanmonstar? I know we hit some problems w/ |
Co-Authored-By: Carl Lerche <me@carllerche.com>
Ping. What are your intentions for this PR? |
Thanks 👍 I made tweaks, primarily |
udoprog
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there's no way for a program to get information about a
JoinError
except to except to scrape itsDisplay
orDebug
implementations. And even though theJoinError
retains the payloadof a panic, there's no way at all to do anything with it since the
Display
andDebug
implementations don't show it.Solution
This adds
is_cancelled()
andis_panic()
methods toJoinError
, as well as aninto_panic()
method which, when applicable, returns the payload of the panic.