CurrentThread::turn should block on idle. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug where `CurrentThread::turn` is expected to block even if the executor is idle. The `turn` API is the low level interface for callers to interact with the `Sleep` instance used by the `CurrentThread` instance. As such, a call to `turn` is expected to call `sleep` once if the executor did not perform any work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where
CurrentThread::turnis expected to blockeven if the executor is idle.
The
turnAPI is the low level interface for callers to interact withthe
Sleepinstance used by theCurrentThreadinstance. As such, acall to
turnis expected to callsleeponce if the executor did notperform any work.