sync: reduce memory size of watch::Receiver #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
reviewed
Jan 28, 2020
There was a problem hiding this comment.
The change to using Arc addresses instead of separate ID values seems good to me. I am not sure about the change that moves versions out of the Receiver struct into the Arc'd state, as I discussed in my comments. Let me know if I'm misunderstanding what's going on here?
This reduces the `mem::size_of::<watch::Receiver>()` from 4 words to 2. - The `id` is now the pointer of the `Arc<WatchInner>`. - The `ver` is moved into the `WatchInner`.
seanmonstar
force-pushed
the
watch-diet
branch
from
a5b692e
to
a716760
Compare
carllerche
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
LGTM, thanks. I am +1ing this, but we should resolve @Hawks's feedback before merging.
hawkw
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The size of
watch::Receiverwas 4 words, when it could be smaller.Solution
This reduces the
mem::size_of::<watch::Receiver>()from 4 words to 2.idis now the pointer of theArc<WatchInner>.veris moved into theWatchInner.