Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresolved import in pin! #2281

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fix unresolved import in pin! #2281

merged 1 commit into from
Feb 28, 2020

Conversation

aznhe21
Copy link
Contributor

@aznhe21 aznhe21 commented Feb 28, 2020

Motivation

A new assignment form of pin! macro introduced in v0.2.12 causes 'unresolved import' in this code.

fn main() {
    tokio::pin! {
        let x = 0;
    }
}

Solution

The macro uses crate instead of $crate. This PR fixes this incorrect usage.

@Darksonn Darksonn added the C-bug Category: This is a bug. label Feb 28, 2020
carllerche
carllerche approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carllerche carllerche merged commit 937ae11 into tokio-rs:master Feb 28, 2020
@carllerche carllerche mentioned this pull request Feb 28, 2020
Merged
@aznhe21 aznhe21 deleted the fix-pin-assignment branch February 29, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aznhe21 @carllerche @Darksonn