Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update links in README.md and CONTRIBUTING.md #2609

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

Darksonn
Copy link
Contributor

I had a read-through of the readme and contributing files. I changed a bunch of links, and a few wording things.

I also changed the text regarding the minimum supported rust version to match what we test in our CI. @carllerche can you confirm if this change is correct?

@Darksonn Darksonn added T-docs Topic: documentation C-maintenance Category: PRs that clean code up or issues documenting cleanup. labels Jun 11, 2020
@Darksonn Darksonn requested a review from carllerche June 11, 2020 09:38
@Darksonn Darksonn self-assigned this Jun 11, 2020
Comment on lines +156 to +158
Tokio is built against the latest stable release. The minimum supported version is 1.39.
The current Tokio version is not guaranteed to build on Rust versions earlier than the
minimum supported version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd prefer to leaving "at least three months" as the MSRV policy and also mentioning the current MSRV. (like crossbeam)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK w/ setting it to 1.39 for 0.2. We should have 0.3 "soonish". We probably should revise for 1.0

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @carllerche, are we good with making this change to the description of the MSRV policy?

@carllerche carllerche merged commit 14723f9 into tokio-rs:master Jul 21, 2020
@Darksonn Darksonn deleted the links-readme-contributing branch July 22, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-maintenance Category: PRs that clean code up or issues documenting cleanup. T-docs Topic: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants