doc: update links in README.md and CONTRIBUTING.md #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
T-docs
taiki-e
reviewed
Jun 12, 2020
Comment on lines
+156
to
+158
| Tokio is built against the latest stable release. The minimum supported version is 1.39. | ||
| The current Tokio version is not guaranteed to build on Rust versions earlier than the | ||
| minimum supported version. |
There was a problem hiding this comment.
Personally, I'd prefer to leaving "at least three months" as the MSRV policy and also mentioning the current MSRV. (like crossbeam)
There was a problem hiding this comment.
I'm OK w/ setting it to 1.39 for 0.2. We should have 0.3 "soonish". We probably should revise for 1.0
hawkw
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
This looks good to me. @carllerche, are we good with making this change to the description of the MSRV policy?
carllerche
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a read-through of the readme and contributing files. I changed a bunch of links, and a few wording things.
I also changed the text regarding the minimum supported rust version to match what we test in our CI. @carllerche can you confirm if this change is correct?