Change UnixListener::poll_accept to public
#2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also apply this to the |
taiki-e
reviewed
Sep 19, 2020
taiki-e
added
A-tokio
This makes it consistent with `TcpListener::poll_accept` and other public poll methods the library provides. This particular method is useful for writing generic code that accepts connections since async functions can't easily be used with traits. It is possible to generically accept connections with `Incoming`, however, this doesn't return the incoming `SocketAddr`.
|
Good point. I added/updated the docs. |
We are going to need two PRs to apply it to both. |
|
OK. I will make a second PR when this one gets approved. |
Darksonn
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with
TcpListener::poll_acceptand otherpublic poll methods the library provides. This particular method is
useful for writing generic code that accepts connections since async
functions can't easily be used with traits. It is possible to
generically accept connections with
Incoming, however, this doesn'treturn the incoming
SocketAddr.