test: Make Mock both Send and Sync #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the inner 'rx' of the Mock IO object used an unbound receiver channel for mock 'Actions'. This allowed the Send auto trait implentation to match this object. Mock was recently convernted to use dynamic dispatch, which now needs the marker Send internally inorder for it to also be Send.
hawkw
approved these changes
Mar 9, 2021
|
@LucioFranco I don't normally do PRs, but when I do, its for Tokio :) |
Darksonn
reviewed
Mar 9, 2021
added 2 commits
March 9, 2021 09:36
Updated the mock object to use the `UnboundReceiverStream` from tokio-stream.
Update the Tokio dependency to use the sub-crate vended through the path.
Darksonn
reviewed
Mar 9, 2021
added 2 commits
March 9, 2021 09:49
Removed the path based sub-crate for Tokio.
Updated the Tokio dependency to not use the path based sub-crate syntax.
Darksonn
approved these changes
Mar 9, 2021
|
I'm not entirely sure either. I don't think rebasing will help. |
added 2 commits
March 10, 2021 10:43
|
I spent some time yesterday trying to remove the paths, but couldn't get it working. The main tokio crate tests are failing because |
|
I'm going to merge this PR as-is once CI passes, although I would like to know what is up and fix it in a later PR if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the inner 'rx' of the Mock IO object used an unbound
receiver channel for mock 'Actions'. This allowed Mock to auto
implement Sync. Mock was recently converted to use dynamic
dispatch, which now needs the marker Sync to continue to
implement these traits.
Motivation
I am upgrading our package to use Tokio 1.0. This updated tokio-test from 0.2.1 to 0.4. In the current version,
Mockis notSync.Solution
This change adds the marker trait
Syncto the dynamic dispatch, which should makeMockbothSend + Sync.