doc: Clarify requirements of AsyncFd #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies that users of AsyncFd must set the fd to nonblocking and should only poll readiness after failing to read/write. I made both these mistakes, and Alice Ryhl helped me debug my code. Some of the wording paraphrases her explanation to me.
Darksonn
reviewed
Mar 22, 2021
Darksonn
added
A-tokio
Co-authored-by: Alice Ryhl <alice@ryhl.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that users of AsyncFd must set the fd to nonblocking and should only poll readiness after failing to read/write.
Motivation
As a newcomer, I misunderstood what I needed to do elsewhere in my code to properly use an AsyncFd.
Solution
Add to docs. Alice Ryhl helped me debug my code. Some of the wording paraphrases her explanation to me.