tokio-test: extract assert_elapsed macro #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `assert_elapsed` macro is generally useful for Tokio users. This commit extracts `assert_elapsed` into `tokio-test`. It adapts the macro for general use by using `std::time::Duration` instead of an integral millis value for time comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert_elapsedmacro is generally useful for Tokio users. Thiscommit extracts
assert_elapsedintotokio-test.It adapts the macro for general use by using
std::time::Durationinstead of an integral millis value for time comparison.
Motivation
assert_elapsedis a generally very handy macro when interacting with tokio & time, especially because the 1ms tolerance is required.Solution
Extract the macro into tokio-test in the two locations it was defined, refactor to use the slightly modified macro.