Add owner id for tasks in OwnedTasks #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
carllerche
reviewed
Jul 21, 2021
carllerche
reviewed
Jul 21, 2021
| // the runtime has fully shut down. | ||
| // | ||
| // The assert below is unrelated to this mutex. | ||
| drop(remote_queue); |
There was a problem hiding this comment.
What is the reason to remove this?
There was a problem hiding this comment.
It was never necessary to hold the mutex locked for this long in the first place. It was introduced in #3752.
carllerche
reviewed
Jul 21, 2021
| for task in self.context.tasks.borrow_mut().queue.drain(..) { | ||
| task.shutdown(); | ||
| drop(task); |
There was a problem hiding this comment.
This was changed a bunch of places. I don't see a drop impl added on the type? Why is this changed?
There was a problem hiding this comment.
The type in question is Notified, and it already has a destructor. I changed it because otherwise you need to go through assert_owner to call shutdown. The call to shutdown has been unnecessary since #3955, as the inject queue and similar can no longer hold newly spawned tasks.
carllerche
reviewed
Jul 21, 2021
carllerche
approved these changes
Jul 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
OwnedTasks::removesafe and guarantees that non-Send tasks are not polled on the wrong thread.