Add blocking_recv method to oneshot::Receiver #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
Darksonn
reviewed
Dec 21, 2021
tokio/src/sync/oneshot.rs
Outdated
Comment on lines
1043
to
1045
| pub fn blocking_recv(self) -> Option<T> { | ||
| crate::future::block_on(self).ok() | ||
| } |
There was a problem hiding this comment.
This should be using the RecvError like .await does for consistency.
There was a problem hiding this comment.
Wouldn't that be inconsistent with mpsc::Receiver::blocking_recv and mpsc::UnboundedReceiver::blocking_recv? Both of them return Option.
…s enabled (future::block_on is exported only if it is enabled, but sync module is compiled in any case for use within tokio)
…::blocking_recv()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #4319
Solution
The solution is same as in
mpscchannels, except that method receiver isselfinstead of&mut self.