util: add mutable reference getters for codecs to pinned Framed
#4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio-util
tobz
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously it was not possible to get a mutable reference to the codec of a pinned
Framed/FramedWrite/FramedRead. This shouldn't be a problem because we never access the codec through a pinned reference.Solution
This pr adds the mutable reference getters
Framed::codec_pin_mut,FramedRead::decoder_pin_mutandFramedWrite::encoder_pin_mut.The names were inspired by the
get_pin_mutgetters which return a pinned mutable reference to the underlying io streams. The added getters are slightly different in that they return a normal reference and not a pinned reference, so I'm not completely sure if adapting the same naming scheme is appropriate.